> On Oct. 7, 2021, 7:07 a.m., Kishor Gollapalliwar wrote: > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java > > Lines 120 (patched) > > <https://reviews.apache.org/r/73634/diff/1/?file=2253715#file2253715line124> > > > > Please consider restricting scope of this variable by declaring it > > inside IF block.
Here 'jsonEncKeyByAlgo' variable is required in outer if block as we are using the same in that block. - Mateen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73634/#review223581 ----------------------------------------------------------- On Oct. 7, 2021, 7:30 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73634/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2021, 7:30 a.m.) > > > Review request for ranger, Abhishek Kumar, Dhaval Shah, Abhay Kulkarni, Mehul > Parikh, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-3463 > https://issues.apache.org/jira/browse/RANGER-3463 > > > Repository: ranger > > > Description > ------- > > Avoid use of System.out.println in KMSMetricUtil.java at line numbers 74, 79, > 98, 104. > > > Diffs > ----- > > > kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMSMetricUtil.java > 925d2c76f > > > Diff: https://reviews.apache.org/r/73634/diff/2/ > > > Testing > ------- > > Tested on local VM. > > > Thanks, > > Mateen Mansoori > >
