-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73677/#review223819
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 932 (original), 932 (patched)
<https://reviews.apache.org/r/73677/#comment312880>

    Also while going through the code, I noticed that similar check is missing 
for getGroups, getGroupUsers, and updateUserRoles. Can you please add?


- Sailaja Polavarapu


On Nov. 22, 2021, 9:40 p.m., David Mollitor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73677/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2021, 9:40 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3285: Off-By-One Error in XUser Syncing
> 
> 
> Diffs
> -----
> 
>   
> ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
>  60445043f 
> 
> 
> Diff: https://reviews.apache.org/r/73677/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Mollitor
> 
>

Reply via email to