----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73783/#review223926 -----------------------------------------------------------
kms/config/kms-webapp/dbks-site.xml Lines 301 (patched) <https://reviews.apache.org/r/73783/#comment312972> can you please add description of each Properties kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java Lines 64 (patched) <https://reviews.apache.org/r/73783/#comment312970> this boolean flag can be directly initialized kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java Lines 65 (patched) <https://reviews.apache.org/r/73783/#comment312971> please add couple of logger Statements kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Line 96 (original), 97 (patched) <https://reviews.apache.org/r/73783/#comment312969> please make sure we are not breaking the existing functionality as you removed RangerKeyVaultKeyGenerator object. kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java Line 966 (original), 973 (patched) <https://reviews.apache.org/r/73783/#comment312968> RangerKMSMKI rangerKVKeyGenerator ==> update argument name pom.xml Lines 182 (patched) <https://reviews.apache.org/r/73783/#comment312973> can we update the version of existing variable?(at above line) - bhavik patel On Jan. 4, 2022, 11:20 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73783/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2022, 11:20 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, > Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep > Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan > Periasamy. > > > Bugs: RANGER-3569 > https://issues.apache.org/jira/browse/RANGER-3569 > > > Repository: ranger > > > Description > ------- > > Ranger KMS integration with Google cloud HSM > - This task is to integrate the RANGER KMS Service with Google Cloud HSM. > - To Configure RANGER KMS Service with Google Cloud HSM below configurations > need to be added in install.properties file bfore running the setup.sh > > IS_GCP_ENABLED=true > GCP_KEYRING_ID=YourKeyRingId > GCP_CRED_JSON_FILE=/full/path/to/downloadedCredfile.json > GCP_PROJECT_ID=YourProjectId > GCP_LOCATION_ID=LocationId > GCP_MASTER_KEY_NAME=MyMasterKeyNameChangeIt > > - Run the setup.sh, It will add the below configs in dbks-site.xml > > <property> > <name>ranger.kms.gcp.enabled</name> > <value>false</value> > <description></description> > </property> > <property> > <name>ranger.kms.gcp.keyring.id</name> > <value></value> > <description></description> > </property> > <property> > <name>ranger.kms.gcp.cred.file</name> > <value></value> > <description></description> > </property> > <property> > <name>ranger.kms.gcp.project.id</name> > <value></value> > <description></description> > </property> > <property> > <name>ranger.kms.gcp.location.id</name> > <value></value> > <description></description> > </property> > <property> > <name>ranger.kms.gcp.masterkey.name</name> > <value></value> > <description></description> > </property> > > - Start the kms service, On start Master Key should be created in Google > Cloud HSM. > > > Diffs > ----- > > distro/src/main/assembly/kms.xml aacdcf103 > kms/config/kms-webapp/dbks-site.xml 75f21c80e > kms/pom.xml b940e75c0 > kms/scripts/MigrateMKeyStorageDbToGCP.sh PRE-CREATION > kms/scripts/install.properties 4cf79080f > kms/scripts/setup.sh 60c026b80 > kms/src/main/java/org/apache/hadoop/crypto/key/MigrateDBMKeyToGCP.java > PRE-CREATION > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerGoogleCloudHSMProvider.java > PRE-CREATION > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKMSMKI.java 75e70fffa > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java > b9e7cb2fd > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > db8fa69e0 > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyVaultKeyGenerator.java > 854d7f0b6 > kms/src/main/resources/META-INF/context.xml PRE-CREATION > pom.xml 5c621a5b4 > > > Diff: https://reviews.apache.org/r/73783/diff/2/ > > > Testing > ------- > > Build Succeeded - mvn clean compile test verify install > Testing : Verified fresh and upgrade scenarios. > > > Thanks, > > Mateen Mansoori > >
