----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73792/#review223942 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On Jan. 7, 2022, 8:23 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73792/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2022, 8:23 p.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, > Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3578 > https://issues.apache.org/jira/browse/RANGER-3578 > > > Repository: ranger > > > Description > ------- > > Current design for creating policy-labels involves creating ad-loc > transaction and synchronized block. This may lead to concurrency issues when > multiple clients are creating/updating policies with same labels. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 85adda54b > > security-admin/src/main/java/org/apache/ranger/service/RangerPolicyLabelHelper.java > 2e17092cf > > > Diff: https://reviews.apache.org/r/73792/diff/1/ > > > Testing > ------- > > Ran all unit tests successfully. > Used ranger-admin docker container to verify > - policy updated with labels is saved and retrieved correctly. > - policy updated by removing labels is saved and retrieved correctly. > > > Thanks, > > Abhay Kulkarni > >
