----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73768/#review223980 -----------------------------------------------------------
Ship it! Ship It! - Pradeep Agrawal On Jan. 20, 2022, 5:36 p.m., Mahesh Bandal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73768/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2022, 5:36 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3551 > https://issues.apache.org/jira/browse/RANGER-3551 > > > Repository: ranger > > > Description > ------- > > Created new GET API "/permissionlist" to reduce response object size of the > permission listing page. Introduced two new java classes > VXModulePermission.java & VXModulePermissionList.java > With these changes, new API will return list of Modules which will have > moduleId, moduleName, list of users & groups asssigned to that module. > Also, optimized code for GET API /permission/{id} > Updated testcases for updateXModuleDefPermission > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java f7a52f095 > security-admin/src/main/java/org/apache/ranger/biz/XUserMgrBase.java > 3ea44655d > security-admin/src/main/java/org/apache/ranger/common/SearchCriteria.java > 201668013 > security-admin/src/main/java/org/apache/ranger/db/XXGroupPermissionDao.java > 265eb33ca > security-admin/src/main/java/org/apache/ranger/db/XXUserPermissionDao.java > bb85e6bed > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java > 4b9085ddb > > security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java > 857a00213 > > security-admin/src/main/java/org/apache/ranger/service/XGroupPermissionService.java > da88e3efb > > security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java > 2d5e2f18b > > security-admin/src/main/java/org/apache/ranger/service/XUserPermissionService.java > 963a89407 > security-admin/src/main/java/org/apache/ranger/view/VXModulePermission.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/view/VXModulePermissionList.java > PRE-CREATION > security-admin/src/main/resources/META-INF/jpa_named_queries.xml c19ec495e > > security-admin/src/main/webapp/scripts/collection_bases/VXModuleDefListBase.js > 3ebee8f9a > security-admin/src/main/webapp/scripts/utils/XAUtils.js bddf53dd9 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > cd4641fd0 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > bee65bb05 > > security-admin/src/test/java/org/apache/ranger/service/TestXGroupPermissionService.java > f88b23aca > > > Diff: https://reviews.apache.org/r/73768/diff/4/ > > > Testing > ------- > > 1. Ranger maven build successful -> mvn clean compile verify test install > 2. Ranger Setup & install successful > 3. Performed sanity testing. > 4. For 100,000 users "/permissionlist" api takes 800~1000 millisecods to > respond with object size= 5Mb. On Ranger GUI it takes 17 seconds to process > complete request. (i.e Total time taken by API = 17 seconds) > > > Thanks, > > Mahesh Bandal > >
