----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73830/#review224019 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Feb. 3, 2022, 8:17 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73830/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2022, 8:17 p.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-3605 > https://issues.apache.org/jira/browse/RANGER-3605 > > > Repository: ranger > > > Description > ------- > > updated expression evaluator to expand macros before evaluating > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > e3ce559da > > agents-common/src/main/java/org/apache/ranger/plugin/util/MacroProcessor.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java > ab0e3b715 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java > 2a0b027a1 > > agents-common/src/test/java/org/apache/ranger/plugin/util/MacroProcessorTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/73830/diff/1/ > > > Testing > ------- > > - added unit tests to cover new functionality > - all existing unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
