----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73833/#review224028 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java Lines 103 (patched) <https://reviews.apache.org/r/73833/#comment313015> Please consider having default value as false. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java Lines 133 (patched) <https://reviews.apache.org/r/73833/#comment313016> Why is this explicitly removed from the context? agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java Lines 613 (patched) <https://reviews.apache.org/r/73833/#comment313017> If the policyDelta indicates if the policy is deleted, then getPolicy() will return a dummy place-holder policy with only policy-id properly set. Any calls on such policy will always return false, and when the only policy with reference to user/group variable referenece is deleted, the user-store will continue to be downloaded unnecessarily. Please review. - Abhay Kulkarni On Feb. 9, 2022, 8:37 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73833/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2022, 8:37 p.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3609 > https://issues.apache.org/jira/browse/RANGER-3609 > > > Repository: ranger > > > Description > ------- > > updated plugin to automatically add userStoreEnricher when any policy has > references to user/group attributes > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > a787c789f > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java > 315328d65 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 9b72a1b73 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 827fb1fc6 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java > 4415b6c04 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPluginCapability.java > b2cecc1f9 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > e5ab8daaa > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestExprResolver.java > 2e486eda4 > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > b76c96ebc > > agents-common/src/test/java/org/apache/ranger/plugin/util/ServiceDefUtilTest.java > PRE-CREATION > > knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java > 624228e4c > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java > 198b940df > security-admin/src/main/resources/conf.dist/security-applicationContext.xml > 3e067a61f > > > Diff: https://reviews.apache.org/r/73833/diff/6/ > > > Testing > ------- > > - added unit tests > - verified that existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
