----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73853/#review224100 -----------------------------------------------------------
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Line 580 (original), 627 (patched) <https://reviews.apache.org/r/73853/#comment313054> Can you please check the indentation? plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 648 (patched) <https://reviews.apache.org/r/73853/#comment313055> Can you please check the indentation? plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Line 601 (original), 660 (patched) <https://reviews.apache.org/r/73853/#comment313056> Same as above - Sailaja Polavarapu On Feb. 22, 2022, 4:26 p.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73853/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2022, 4:26 p.m.) > > > Review request for ranger, Mehul Parikh, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3628 > https://issues.apache.org/jira/browse/RANGER-3628 > > > Repository: ranger > > > Description > ------- > > Modifying ranger solr plugin to allow granting the following privileges: > > - QUERY - read only privilege on an object > - UPDATE - write only privilege on an object > - All - read and write access > > Privileges can be defined on the following objects: > > - admin > - collections > - cores > - metrics > - autoscaling > - security > - collection > - config > - schema > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > dfaa2f701 > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuditHandler.java > 359211cb2 > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > d4dd7b0ec > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/SolrAuthzUtil.java > PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerServiceSolr.java > 97909ae54 > > plugin-solr/src/main/java/org/apache/ranger/services/solr/RangerSolrConstants.java > PRE-CREATION > > plugin-solr/src/main/java/org/apache/ranger/services/solr/client/ServiceSolrClient.java > 5f7b9b924 > > > Diff: https://reviews.apache.org/r/73853/diff/1/ > > > Testing > ------- > > Tested on cluster with by covering test cases as per new implementation. > > > Thanks, > > Mateen Mansoori > >