----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73857/#review224103 -----------------------------------------------------------
1. add options of access_log // set it to false will disable log rotation ranger.accesslog.rotate.enabled = true on default // set it to true will result in the current access log name without dateformat. ranger.accesslog.rotate.rename_on_rotate = false on default 2. rename max.days to max_days, make the name look more comfortable ranger.accesslog.rotate.max.days = 15 3. move "-" from default prefix to default dateformat // It can helps for using access log name without dateformat default ACCESS_LOG_PREFIX: "access-" + hostName default ACCESS_LOG_DATE_FORMAT: "-yyyy-MM-dd.HH" 4. mv ews/webapp/WEB-INF/logback.xml to ews/webapp/WEB-INF/classes/conf[.dist] It can helps person to adjust log options easier. 5. add "%D" to default access-log It can help admins to get timecost from access-log instead of expansive perf log. 6. fix a lot of log4j name remains to logback. I mean say you have to remove this description. - bhavik patel On Feb. 26, 2022, 12:59 a.m., Kirby Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73857/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2022, 12:59 a.m.) > > > Review request for ranger and madhan. > > > Bugs: RANGER-3632 > https://issues.apache.org/jira/browse/RANGER-3632 > > > Repository: ranger > > > Description > ------- > > 1. add options of access_log > > # set it to false will disable log rotation > ranger.accesslog.rotate.enabled = true on default > # set it to true will result in the current access log name without > dateformat. > ranger.accesslog.rotate.rename_on_rotate = false on default > > 2. rename max.days to max_days, make the name look more comfortable > ranger.accesslog.rotate.max.days = 15 > > 3. move "-" from default prefix to default dateformat > # It can helps for using access log name without dateformat > valve.setPrefix(EmbeddedServerUtil.getConfig(ACCESS_LOG_PREFIX,"access-" + > hostName)); > > valve.setFileDateFormat(EmbeddedServerUtil.getConfig(ACCESS_LOG_DATE_FORMAT, > "-yyyy-MM-dd.HH")); > > 4. mv ews/webapp/WEB-INF/logback.xml to ews/webapp/WEB-INF/classes/conf[.dist] > # It can helps person to adjust log options easier. > > 5. add "%D" to default access-log > # It can help admins to get timecost from access-log instead of expansive > perf log. > > 6. fix a lot of log4j name remains to logback. > > > Diffs > ----- > > dev-support/ranger-docker/scripts/ranger-admin-install.properties > f4e623c5aa2865e29e756359eb9a2c4f33f58e36 > embeddedwebserver/scripts/ranger-admin-services.sh > 54ac410561a34f069c2f62e8a5d2467de4e43bed > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 93ba6c0f936e9306336d42075f8566e009347367 > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServerUtil.java > b05db77e6acbf7c11631c3feae1b660d522e1ea5 > ranger-tools/scripts/README.txt 81b5b6678174dd9da79aa083fbe4b73ce8e4bc94 > security-admin/scripts/changepasswordutil.py > d53cde44378306a3b104d4e6d42c56b5dc7ccbcf > security-admin/scripts/changeusernameutil.py > 0c20bb6ed4f535365986555ba24d6a1531fc3392 > security-admin/scripts/db_setup.py 5e757aca30d01c244b5b0e4efa356b11c65aa7aa > security-admin/scripts/install.properties > 03f6cd7f6f98657ed12ed0f6ccc51bacdbd3afd5 > security-admin/scripts/rolebasedusersearchutil.py > 500aa624fa12d216e3fca1c58404b6100cafcb8c > security-admin/scripts/setup.sh 6b001cf59e8d21891ccae614ed51f0a30cb4bde4 > security-admin/scripts/updateUserAndGroupNamesInJson.py > 02d95d7816df28dc900fed73522e2e53dbfbd665 > security-admin/src/bin/ranger_install.py > 90ac92a0ea2abf60aadbdcad5054e843a5d90530 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 0a1128613dca50fe67ea3f891261f1ee449c46db > security-admin/src/main/webapp/WEB-INF/db_patch.log4j.xml > security-admin/src/main/webapp/WEB-INF/log4j.dev.xml > 45ca9237f77c1130caaa5e08f3058ecc7e636a0b > security-admin/src/main/webapp/WEB-INF/log4j.xml > 359ed93600947d21d5f4d1ee3779e6e3b8213ce2 > security-admin/src/main/webapp/WEB-INF/logback.xml > security-admin/src/test/resources/log4j.xml > 15ae2741c37e02f55bfb3546f21c71c9b0036260 > tagsync/conf.dist/log4j.xml d455509326bfe6f598a48ee6e3f2a4b0d5f621e7 > tagsync/scripts/setup.py 29ad7fa885697534748b76187070a4ffa177633f > unixauthservice/conf.dist/log4j.xml > 0ef266bfd942181d7cf766bd40e5ce02b8a6be7a > unixauthservice/scripts/setup.py 9639eb4254cb465882144b03cec859f6a0ae98b5 > > > Diff: https://reviews.apache.org/r/73857/diff/3/ > > > Testing > ------- > > mvn package > clean installation and upgrade. > > > Thanks, > > Kirby Zhou > >
