-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73913/
-----------------------------------------------------------

(Updated 三月 25, 2022, 9:33 a.m.)


Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, and Velmurugan 
Periasamy.


Changes
-------

1. add a new named query to return ids
2. add some comments in code


Bugs: RANGER-3681
    https://issues.apache.org/jira/browse/RANGER-3681


Repository: ranger


Description
-------

Modify delete sql to delete according to the primary key, to solve the problem 
of deadlock under REPEATABLE-READ isolation level


Diffs (updated)
-----

  
src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java
 b9a60cb 
  
src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefConditionDao.java
 e14bc14 
  
src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefDataMaskTypeDao.java
 7e7b8d4 
  
src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefGroupDao.java 
5f9d9ed 
  
src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefResourceDao.java
 0ea7de9 
  src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java 
3ae7e7a 
  src/security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefUserDao.java 
518139a 
  src/security-admin/src/main/resources/META-INF/jpa_named_queries.xml 5813209 


Diff: https://reviews.apache.org/r/73913/diff/2/

Changes: https://reviews.apache.org/r/73913/diff/1-2/


Testing
-------

1. Calles the createPolicy() method 1000 times using two threads. The results 
showed that all policies are successfully created without deadlock exception.
2. Calles the updatePolicy() method 1000 times using two threads. The results 
showed that all policies are successfully updated without deadlock exception.
3. Calles the deletePolicy() method 1000 times using two threads. The results 
showed that all policies are successfully deleted.


Thanks,

Xuze Yang

Reply via email to