----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73954/#review224390 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 144 (patched) <https://reviews.apache.org/r/73954/#comment313221> if updateDefaultAuditFilter execution fails then also patch will continue. is this intentional ? security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 145 (patched) <https://reviews.apache.org/r/73954/#comment313220> should this be logger.error or logger.info ? security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 486 (patched) <https://reviews.apache.org/r/73954/#comment313222> add null check on embeddedAtlasServiceDef before calling embeddedAtlasServiceDef.getConfigs(); security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java Lines 498 (patched) <https://reviews.apache.org/r/73954/#comment313223> i think we should move this line after 499 - Pradeep Agrawal On April 29, 2022, 9:06 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73954/ > ----------------------------------------------------------- > > (Updated April 29, 2022, 9:06 a.m.) > > > Review request for ranger, bhavik patel, Dhaval Shah, Mehul Parikh, Pradeep > Agrawal, Ramesh Mani, and Velmurugan Periasamy. > > > Bugs: RANGER-3725 > https://issues.apache.org/jira/browse/RANGER-3725 > > > Repository: ranger > > > Description > ------- > > Update atlas default audit filter to filter Atlas entity-read events by Nifi > user. > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-atlas.json > 7495b794d > > security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java > 345e26ddb > > > Diff: https://reviews.apache.org/r/73954/diff/2/ > > > Testing > ------- > > Tested on local VM - Audit filters are populating as expected. > - verified upgrade case. > > > Thanks, > > Mateen Mansoori > >
