[
https://issues.apache.org/jira/browse/RANGER-3752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17535894#comment-17535894
]
kirby zhou commented on RANGER-3752:
------------------------------------
I understand the issue and what the code to do, Your solution is filter out
duplicate at validation stage.
But the function name "isValidItemAccesses" strongly implies that it has no
side effects. This makes it more difficult for future developer to understand
the code.
My suggestion is to either change the name of the function or use your policy-2
"if there are any duplicate entries then fail the policy request."
> Restrict duplicate access types entries in policy creation
> ----------------------------------------------------------
>
> Key: RANGER-3752
> URL: https://issues.apache.org/jira/browse/RANGER-3752
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
> Reporter: Pradeep Agrawal
> Assignee: Pradeep Agrawal
> Priority: Major
> Fix For: 3.0.0
>
> Attachments:
> 0001-RANGER-3752-Restrict-duplicate-access-types-entries-.patch
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
