> On Sept. 21, 2022, 8:13 a.m., Kirby Zhou wrote: > > It seems work. > > > > But are you sure you want to change the log level of com.mchange from the > > default warn to error? > > What's the reason? > > Ramachandran Krishnan wrote: > The existing behaviour for the logger name com.mchange ,we kept error > level only .So I was thinking of keeping error level.You are right the > default level is warn which i was overriding into error for the logger name > com.mchange (anyway the same logger name already present in the > logback.xml.We only changed into the different appender) > > Ramachandran Krishnan wrote: > Is there any specific reason to keep into warn for the logger name > com.mchange (backed by c3p0) ? > > Kirby Zhou wrote: > The old version of c3p0 is running with level='warn' for years. > If there is no specific reason, we should not change it.
Sure , we will keep it warn instead of changing to erro level - Ramachandran ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74131/#review224690 ----------------------------------------------------------- On Sept. 23, 2022, 8:34 a.m., Ramachandran Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74131/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2022, 8:34 a.m.) > > > Review request for ranger, Madhan Neethiraj and Pradeep Agrawal. > > > Bugs: RANGER-3775 > https://issues.apache.org/jira/browse/RANGER-3775 > > > Repository: ranger > > > Description > ------- > > {logger name="com.mchange"} > is used by c3p0 and {logger name="jdbc.connection"} > > is used by log4jdbc > > <logger name="jdbc.connection" additivity="false" level="error"> > <appender-ref ref="sql_appender"/> > </logger> > <logger name="com.mchange" additivity="false" level="warn" /> > > > Diffs > ----- > > security-admin/src/main/resources/conf.dist/logback.xml 53cdc49cf > > > Diff: https://reviews.apache.org/r/74131/diff/3/ > > > Testing > ------- > > > Thanks, > > Ramachandran Krishnan > >
