> On 九月 28, 2022, 9:15 a.m., Kirby Zhou wrote: > > Why modify filterListCmdObjects() only?
filterListCmdObjects() will filter out any objects that should not be shown to the user, from the list of tables or databases coming from a 'show tables' or 'show databases' command. This patch gives an option to disable record audit logs for every tables or databases when execute 'show' sql. checkPrivileges() will record one audit log about 'show' sql(accetype is USE), and this audit log is valuable, we should keep it. I would like to know what else needs to be changed, can you give more hints? Thanks - Xuze ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74136/#review224707 ----------------------------------------------------------- On 九月 24, 2022, 2:37 p.m., Xuze Yang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74136/ > ----------------------------------------------------------- > > (Updated 九月 24, 2022, 2:37 p.m.) > > > Review request for ranger, Kirby Zhou, Abhay Kulkarni, and Madhan Neethiraj. > > > Bugs: RANGER-3685 > https://issues.apache.org/jira/browse/RANGER-3685 > > > Repository: ranger > > > Description > ------- > > hive show sql produces too many audit logs, which will flood valuable audit > logs and take up a lot of storage resources. This patch aims to provide a > configuration item to support simplified hive audit logging > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java > 6675125e1 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > 8f6801be1 > > > Diff: https://reviews.apache.org/r/74136/diff/1/ > > > Testing > ------- > > 1. when configuration "xasecure.hive.simplify.audit.of.hive.show.sql" is not > set or set to false. The code behaves the same as before,i.e record audit > logs for each databases or tables > 2. when configuration "xasecure.hive.simplify.audit.of.hive.show.sql" is set > to true. It will only record an audit log about USE operation > > > Thanks, > > Xuze Yang > >
