----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74182/#review224829 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java Lines 345 (patched) <https://reviews.apache.org/r/74182/#comment313697> Is there any statistics about the memory savings with this change? Also, any data about the extra processing time required for de-duplicating strings? agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java Lines 512 (patched) <https://reviews.apache.org/r/74182/#comment313699> Wouldn't just return ret; suffice here? security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java Lines 378 (patched) <https://reviews.apache.org/r/74182/#comment313698> If the number of newly added/modified service-resources and/or tags is small, then de-deplicating entire updated serviceTags is wasteful. Can this be moved inside RangerServiceTagsDeltaUtil.applyDelta() function? Same comment for handling of ServicePoliciesCache. - Abhay Kulkarni On Oct. 26, 2022, 7:09 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74182/ > ----------------------------------------------------------- > > (Updated Oct. 26, 2022, 7:09 a.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, Subhrat > Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3955 > https://issues.apache.org/jira/browse/RANGER-3955 > > > Repository: ranger > > > Description > ------- > > - added dedupStrings() method in ServicePolicies, ServiceTags and > RangerUseStore > - added Ranger admin options to dedup strings in policies/tags/userstore > caches > - added Ranger plugin configuration to dedup strings in > policies/tags/userstore cache > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/utils/StringUtil.java > e6c96028a > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > c3d1e7da6 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreEnricher.java > a6dd38705 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerBaseModelObject.java > 70c0a42e4 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > af8150519 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyDelta.java > 282696344 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > cd8b5d186 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceResource.java > 1c46ea5c2 > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTag.java > 4154ea32b > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerTagDef.java > 6fc6f9553 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > dc51078a7 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerUserStore.java > 0352c53dc > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java > fd033f05c > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceTags.java > 8a94d9a2e > > agents-common/src/test/java/org/apache/ranger/authorization/utils/TestStringUtil.java > PRE-CREATION > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > 961e87fbf > > security-admin/src/main/java/org/apache/ranger/common/RangerServiceTagsCache.java > 4d80ccb18 > > security-admin/src/main/java/org/apache/ranger/common/RangerUserStoreCache.java > 0cb0ccca8 > > > Diff: https://reviews.apache.org/r/74182/diff/1/ > > > Testing > ------- > > - added unit tests to validate dedup > - verified that all existing unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
