> On Oct. 26, 2022, 2:15 p.m., Abhay Kulkarni wrote: > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json > > Line 383 (original), 383 (patched) > > <https://reviews.apache.org/r/74167/diff/1/?file=2270656#file2270656line383> > > > > This test used to fail. Does the change in RangerScheduleValidator.java > > (lines 366 and 375) fix that failure?
Yes, that is correct. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74167/#review224830 ----------------------------------------------------------- On Oct. 14, 2022, 5:40 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74167/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2022, 5:40 a.m.) > > > Review request for ranger, Ankita Sinha, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja > Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-3888 > https://issues.apache.org/jira/browse/RANGER-3888 > > > Repository: ranger > > > Description > ------- > > - updated unit tests to add more details in failure messages to make > troubleshooting easier > - updated tests for valid range for month: 0-11 > - updated validation logic to fail only when a given range is completely > outside the valid range; earlier validation used to fail even if either min > or max fall out of range > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidityScheduleValidator.java > 1e38118f7 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > 59c50e4ca > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-invalid.json > 321df659f > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid-and-applicable.json > 76489094a > > agents-common/src/test/resources/policyengine/validityscheduler/test-validity-schedules-valid.json > d42d3e6d1 > > > Diff: https://reviews.apache.org/r/74167/diff/1/ > > > Testing > ------- > > - verified that TestPolicyEngine tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
