----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74192/ -----------------------------------------------------------
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy. Bugs: RANGER-3961 https://issues.apache.org/jira/browse/RANGER-3961 Repository: ranger Description ------- At AuditFileSpool.java#L904, the variable lines holds all the events that are in current batch, that is 1000 by default (~0.5MB of strings). The batch can be configured even higher that makes things worse. If there is an issue in audit, a lot of huge strings will be logged out. Suggesting to remove lines variable and/or add lines.size() to know how many events were not sent. Diffs ----- agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java edce2461a Diff: https://reviews.apache.org/r/74192/diff/1/ Testing ------- 1. Ranger maven build successful -> mvn clean compile verify test install 2. Ranger Setup & install successful 3. Performed sanity testing. Thanks, Mahesh Bandal