----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74266/#review225051 -----------------------------------------------------------
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx Lines 366 (patched) <https://reviews.apache.org/r/74266/#comment313861> No need to set state to true again in the catch. Please check similar kind of implementation done in other files. security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx Lines 163 (patched) <https://reviews.apache.org/r/74266/#comment313859> Create separate function to manage : -- calling of deleteZone parent component props function -- setting the state for modal close security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx Line 1 (original) <https://reviews.apache.org/r/74266/#comment313857> License text is getting removed. Please add it back. security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx Lines 47 (patched) <https://reviews.apache.org/r/74266/#comment313858> Create a seperate function to manage loader show/hide state. security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx Line 552 (original), 554 (patched) <https://reviews.apache.org/r/74266/#comment313860> Create separate function to manage : -- calling of deleteService parent component props function -- setting the state for modal close - Mugdha Varadkar On Jan. 3, 2023, 10:37 a.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74266/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2023, 10:37 a.m.) > > > Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, > Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4030 > https://issues.apache.org/jira/browse/RANGER-4030 > > > Repository: ranger > > > Description > ------- > > Improving content loader for loading pages in Ranger React > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx > fa51909fa > security-admin/src/main/webapp/react-webapp/src/images/blockLoading.gif > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/styles/style.css 8ededa2ec > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx > 900914e26 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx > 4d5e105dd > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx > 1406079a1 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx > ade612741 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx > 18456b48b > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx > fa135e3fc > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx > 286bffad5 > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx > c0b8ce55e > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx > 3df287dd6 > > security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx > 82459b404 > > security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx > c320eeff1 > > security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/Permissions.jsx > 95178d6a3 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > dc1adc0a7 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx > eae2e5be6 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx > 2d3cf7e62 > > security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx > e26f0eba9 > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx > aeb8cd407 > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx > 7844a523a > > security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx > d8bcc1cf1 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ExportPolicy.jsx > 894291d4e > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx > 255e29a72 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx > 79dfe339b > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > e284b9b7b > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > c68ebe62f > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx > 470432ea7 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx > 188572488 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx > 8a551f9e3 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx > c18ddfa1c > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx > 69b38d1c3 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx > 00a3e9e84 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx > 19a3dfd6e > security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx > a7a31a0d7 > > > Diff: https://reviews.apache.org/r/74266/diff/1/ > > > Testing > ------- > > 1)Build and Verified Ranger Admin setup with this changes > 2)Verified content loader for crud operations on following pages - Service > Form, Policy Form, User/Group/Role Form, import/export Form. > > > Thanks, > > Brijesh Bhalala > >
