----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74325/#review225225 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On Feb. 27, 2023, 2:07 p.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74325/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2023, 2:07 p.m.) > > > Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh, > Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4093 > https://issues.apache.org/jira/browse/RANGER-4093 > > > Repository: ranger > > > Description > ------- > > Behaviour in React UI: > > On the create role page when "Add user", "Add group" and "Add role" button is > clicked without selecting any user, group or roles continuously it shows a > lot of popups. > > > > Behaviour in Backbone JS UI: > > Shows a single dialog box with no user, group or role selected and the page > is blocked until the prompt is removed by clicking OK or it automatically > gone after some time. > > > > Expected Behaviour: > > It should block the page for some time until the popup goes away or not show > multiple popups. > > > > Steps to reproduce: > # Navigate to create role page of ranger UI > # Click on "Add Users"/"Add Groups"/"Add Roles" button continuously. > # Lot of popups with msg "Please select at least one user" appear on right > side of screen. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/styles/style.css e05fa2b51 > > security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx > 14620a63b > > > Diff: https://reviews.apache.org/r/74325/diff/1/ > > > Testing > ------- > > 1)Build and Verified Ranger Admin setup with this changes. > 2)Verified the following things :- > - CRUD Operation for Role Module > - Role Listing Table > > > Thanks, > > Brijesh Bhalala > >
