----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74335/#review225245 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java Lines 107 (patched) <https://reviews.apache.org/r/74335/#comment313975> Will this be added in upgrade scenario also? - Ramesh Mani On March 3, 2023, 6:06 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74335/ > ----------------------------------------------------------- > > (Updated March 3, 2023, 6:06 a.m.) > > > Review request for ranger, Abhishek Kumar, Ankita Sinha, Kishor > Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, > Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4117 > https://issues.apache.org/jira/browse/RANGER-4117 > > > Repository: ranger > > > Description > ------- > > - when a service-def has option enableImplicitConditionExpression set to > true, Ranger will automatically include condition-def named _expression of > type RangerScriptConditionEvaluator > - default value for this option is derived from Ranger admin configuration > ranger.servicedef.enableImplicitConditionExpression > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceDef.java > 05dde4edf > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > fe1cf9244 > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 6cc3509d8 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceDefService.java > 954c10e74 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerServiceDefService.java > 032f2f870 > > > Diff: https://reviews.apache.org/r/74335/diff/1/ > > > Testing > ------- > > - verified that policy UI shows expression condition for all services > - verified CRUD of policies that use expression condition > - added unit tests to verify implicit addition of expression condition-def > - verified that all unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
