----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74336/#review225251 -----------------------------------------------------------
Ship it! Ship It! - Ramesh Mani On March 4, 2023, 9:53 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74336/ > ----------------------------------------------------------- > > (Updated March 4, 2023, 9:53 a.m.) > > > Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay > Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and > Subhrat Chaudhary. > > > Bugs: RANGER-4121 > https://issues.apache.org/jira/browse/RANGER-4121 > > > Repository: ranger > > > Description > ------- > > - updated security-zone validation API to use Objects.equals() to avoid NPE > - updated validation to handle public group in zone.adminUserGroups and > zone.auditUserGroups > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java > 9ea222401 > security-admin/src/main/java/org/apache/ranger/rest/SecurityZoneREST.java > 5dcde8678 > > > Diff: https://reviews.apache.org/r/74336/diff/1/ > > > Testing > ------- > > - verified that updating security-zone with null for description doesn't > result in NPE > - verified that all unit tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
