-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74324/
-----------------------------------------------------------
(Updated March 30, 2023, 7:39 a.m.)
Review request for ranger, Dhaval Rajpara, Madhan Neethiraj, Mehul Parikh,
Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.
Bugs: RANGER-4092
https://issues.apache.org/jira/browse/RANGER-4092
Repository: ranger
Description
-------
Behaviour in React UI:
Showing multiple success/failure msg prompts for multiple users/groups
visibility toggle with same msg.
Behaviour in Backbone JS UI:
Shows a dialog box once with users/groups already visible or already hidden if
all the selected users/groups are in the state which it was supposed to acquire.
Expected behaviour:
Either it shows the combine one status that users/groups are already hidden or
visible as in already present UI.
Or
If shows individual popups then show with name for eg.
For users: "Selected user {user_name} is already hidden or visible" instead of
just showing "Selected user is already hidden or visible".
For groups: "Selected groups group_name} is already hidden or visible" instead
of just showing "Selected group is already hidden or visible".
Steps to reproduce:
# Create 4 users user_1, user_2, user_3, user_4 in ranger.
# Then in users table of users page in ranger UI select those 4 users.
# Then from set visibility dropdown select visible.
# 4 popups can be seen in the right side of page with same msg as "Selected
user is already visible". And none of the popup contains the name of the user
to which it was concerned to.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx
1bdf52e16
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx
38a345108
Diff: https://reviews.apache.org/r/74324/diff/3/
Changes: https://reviews.apache.org/r/74324/diff/2-3/
Testing
-------
1)Build and Verified Ranger Admin setup with this changes.
2)Verified the following things:-
- CRUD Operation for User module
- CRUD Operation for Group module
- Visibility toggle options in User and Group Listing Tables.
Thanks,
Brijesh Bhalala
