> On Feb. 14, 2023, 3:14 p.m., Ramesh Mani wrote: > > hbase-compat-2.4/pom.xml > > Lines 20 (patched) > > <https://reviews.apache.org/r/74299/diff/1/?file=2274385#file2274385line20> > > > > Could you please elaborate why hbase-compact-2.4 and hbase-compact-2.5 > > module is created? > > Rajeshbabu Chintaguntla wrote: > As part of HBASE-26147 preBalance and postBalance coprocessor hooks > syntax changed because of that building ranger with 2.5.x is failing. If we > fix the syntax then we cannot build with versions below 2.5.0. So we need to > have both compatible implementation in our code and depending upon the > profile selected the hbase ragner plugin gets build. > > - public void preBalance(ObserverContext<MasterCoprocessorEnvironment> c) > + public void preBalance(ObserverContext<MasterCoprocessorEnvironment> > c, BalanceRequest request) > throws IOException { > > > > @Override > public void postBalance(final > ObserverContext<MasterCoprocessorEnvironment> ctx, > - List<RegionPlan> plans) throws IOException { > + BalanceRequest request, List<RegionPlan> plans) throws > IOException { > if (!plans.isEmpty()) { > > > Already 3 point releases went in 2.5.x release lines with the > compatibilty issue. > > > hbase-compact-2.4 is for the balance hooks implementations of HBase > versions below 2.5.0 > hbase-compact-2.5 is for the balance hooks implementations of HBase > versions 2.5.0+.
I think it's better to have only one of hbase version-2.5.x - bhavik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74299/#review225187 ----------------------------------------------------------- On Feb. 9, 2023, 12:38 p.m., Rajeshbabu Chintaguntla wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74299/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2023, 12:38 p.m.) > > > Review request for ranger, bhavik patel, Madhan Neethiraj, Ramesh Mani, and > Vishal Suvagia. > > > Bugs: RANGER-4029 > https://issues.apache.org/jira/browse/RANGER-4029 > > > Repository: ranger > > > Description > ------- > > Added HBase compatible implementations balancer hooks for both HBase versions > below 2.5.0 and HBase version starting from HBase 2.5.0. So we can specify > which compabile version of HBase need to be used why building the hbase > ranger plugins. > > > Diffs > ----- > > hbase-agent/pom.xml c6acf9756 > > hbase-agent/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > 281f3ec75 > hbase-compat-2.4/pom.xml PRE-CREATION > > hbase-compat-2.4/src/main/java/org/apache/ranger/authorization/hbase/CompatMasterObserver.java > PRE-CREATION > hbase-compat-2.5/pom.xml PRE-CREATION > > hbase-compat-2.5/src/main/java/org/apache/ranger/authorization/hbase/CompatMasterObserver.java > PRE-CREATION > pom.xml 5d9fd9222 > ranger-hbase-plugin-shim/pom.xml add905f46 > > ranger-hbase-plugin-shim/src/main/java/org/apache/ranger/authorization/hbase/RangerAuthorizationCoprocessor.java > 3e6e5d08c > > > Diff: https://reviews.apache.org/r/74299/diff/1/ > > > Testing > ------- > > Build the ranger with HBase compat profile 2.4 and HBase compat profile 2.5 > and tested those in the real cluster. All the functionality working as > expected. > > > Thanks, > > Rajeshbabu Chintaguntla > >
