----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74472/#review225560 -----------------------------------------------------------
Ship it! Ship It! - Velmurugan Periasamy On June 12, 2023, 6:23 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74472/ > ----------------------------------------------------------- > > (Updated June 12, 2023, 6:23 a.m.) > > > Review request for ranger, bhavik patel, Abhay Kulkarni, Madhan Neethiraj, > Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2895 > https://issues.apache.org/jira/browse/RANGER-2895 > > > Repository: ranger > > > Description > ------- > > This change is taken from PR : https://reviews.apache.org/r/72645/ and have > additional changes due to below details: > > 1) We should replace c3p0 with > [HikariCP|https://github.com/brettwooldridge/HikariCP]. HikariCP is much > faster and less error prone. HikariCP is more popular with 13.2k+ stars on > its github. There were no more new commits since Nov 18, 2019 in > [c3p0|https://github.com/swaldman/c3p0/commits/master]. > > > 2) [MySQL connector|https://github.com/mysql/mysql-connector-j] should be > upgraded to the latest stable versions as well to include many essential > bugfixes. > > 3) Removed audit to DB connection configs and code which is not supported now > > > Diffs > ----- > > pom.xml 3d4a755a2 > security-admin/pom.xml 25aaa0e58 > security-admin/scripts/ranger-admin-site-template.xml 037260f50 > security-admin/scripts/upgrade_admin.py 85f57b8ce > security-admin/src/main/java/org/apache/ranger/db/RangerDaoManager.java > 44375e5ac > security-admin/src/main/java/org/apache/ranger/db/XXAccessAuditDao.java > d6de8423c > security-admin/src/main/resources/META-INF/persistence.xml 20f08d22a > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 68d8a0303 > security-admin/src/main/webapp/META-INF/applicationContext.xml 0923d6007 > > > Diff: https://reviews.apache.org/r/74472/diff/2/ > > > Testing > ------- > > Tested install and upgrade case for mysql, postgres, and oracle DB flavor. > > > Thanks, > > Pradeep Agrawal > >
