Hi Clément, Apache Ranger supports reviews via review board and pull requests via GitHub. Only one of them needs to be followed. I see the PR is already available, I'll add reviewers and once the review is approved it can be merged to master.
Thanks, Abhishek On Mon, Jul 10, 2023 at 7:47 AM Clément <sulray...@gmail.com> wrote: > Hi, > > I can't manage to do a review request on https://reviews.apache.org. > I've made the push of my modifications on my fork of ranger to be able to > create a pull request on apache/ranger (4309 > <https://github.com/apache/ranger/pull/271>) and now I'm completely lost > with the documentation <https://www.reviewboard.org/docs/manual/5.0/users/ > >. > I've tried to do rbt* post --server https://reviews.apache.org/ > <https://reviews.apache.org/> --tracking-branch origin/master *with the > remote branch set to apache/ranger. > And I got this error : > > > ERROR: There don't seem to be any diffs! > > > I've also tried to publish the diff file directly on the webui and I got > this : > > > fatal: git cat-file: could not get object info > > Line undefined: undefined > > > What are the actual steps I'm supposed to follow to be able to just post my > review request ? Thank you ! > > Cheers, > Clément sulray Lucas > > > Le ven. 7 juil. 2023 à 15:04, Clément <sulray...@gmail.com> a écrit : > > > Hi, > > > > Would it be possible to assign me to the RANGER-4309 > > <https://issues.apache.org/jira/browse/RANGER-4309> Jira issue ? I > > already have a pull request ready to be submitted if it's okay with you. > My > > username on Jira is "sulray". > > Thanks ! > > > > Yours sincerely, > > Clément "sulray' Lucas > > >
