----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74514/#review225668 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On July 25, 2023, 11:42 a.m., Dhaval Rajpara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74514/ > ----------------------------------------------------------- > > (Updated July 25, 2023, 11:42 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, Nitin > Galave, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-4119 > https://issues.apache.org/jira/browse/RANGER-4119 > > > Repository: ranger > > > Description > ------- > > Ranger policy UI provides Syntax check button that allows policy authors to > check if condition expression entered is valid or not. This button is > available for condition in policy-item level, but its not available for > condition at policy level - as seen in following images: > > > Diffs > ----- > > agents-common/src/main/resources/service-defs/ranger-servicedef-abfs.json > 7dcf38895 > agents-common/src/main/resources/service-defs/ranger-servicedef-kafka.json > 2f511eff5 > agents-common/src/main/resources/service-defs/ranger-servicedef-knox.json > 410b9ef58 > agents-common/src/main/resources/service-defs/ranger-servicedef-ozone.json > 4b899736b > > agents-common/src/main/resources/service-defs/ranger-servicedef-schema-registry.json > 987a50fc5 > agents-common/src/main/resources/service-defs/ranger-servicedef-solr.json > de3399845 > agents-common/src/main/resources/service-defs/ranger-servicedef-tag.json > 7cb523075 > security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx > ea22b32ad > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 30fc4225b > > security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx > 1f89900eb > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx > 13a8eaf4f > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx > 9498d3fe3 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx > 380c2ec30 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx > f75ddd4c3 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > 83b2b386b > > > Diff: https://reviews.apache.org/r/74514/diff/2/ > > > Testing > ------- > > 1)Build and Verified Ranger Admin setup with these changes. > 2) Validated below scenarios on new UI: > 1. Tested Resource Based/Tag Based/ KMS Policy CRUD and check that policy > Conditions populate properly and give proper validation for text area. > 2. Resource level policy conditions provided run type validation. > 3. Policy Item level policy condition has syntax check button. > > > Thanks, > > Dhaval Rajpara > >
