-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74566/
-----------------------------------------------------------

(Updated Aug. 25, 2023, 8:27 p.m.)


Review request for ranger, Abhay Kulkarni, Monika Kachhadiya, Pradeep Agrawal, 
Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy.


Changes
-------

- default value of ranger.plugin.activity.log.not.modified updated to true i.e. 
plugin download will be logged even with no policy/tag/role/userstore changes 
were provided to the plugin


Bugs: RANGER-4375
    https://issues.apache.org/jira/browse/RANGER-4375


Repository: ranger


Description
-------

- when ranger.log.SC_NOT_MODIFIED=true, x_plugin_info record update is skipped 
if no changes are downloaded to the plugin
- updated RangerTransactionService to support threadpool size via configuration
- updated RangerTransactionService to periodically log status of number of 
pending tasks


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java 1dc3d372d 
  
security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java
 49d07fcd0 


Diff: https://reviews.apache.org/r/74566/diff/2/

Changes: https://reviews.apache.org/r/74566/diff/1-2/


Testing
-------

- verified that update of x_plugin_info record is skipped when no changes are 
downloaded to the plugin
- verified following stats logs:
```
2023-08-25 17:57:24,983 [localhost-startStop-1] INFO 
[RangerTransactionService.java:70] 
ranger.admin.transaction.service.threadpool.size=1
2023-08-25 17:57:24,986 [localhost-startStop-1] INFO 
[RangerTransactionService.java:71] 
ranger.admin.transaction.service.summary.log.interval.sec=300
2023-08-25 17:57:48,638 [http-nio-6080-exec-6] INFO 
[RangerTransactionService.java:141] RangerTransactionService: 
totalScheduledTasks=2, failedTaskCount=0, currentPendingTasks=2
2023-08-25 18:02:25,288 [http-nio-6080-exec-96] INFO 
[RangerTransactionService.java:141] RangerTransactionService: 
totalScheduledTasks=11925, failedTaskCount=0, currentPendingTasks=3967
2023-08-25 18:09:01,908 [http-nio-6080-exec-54] INFO 
[RangerTransactionService.java:141] RangerTransactionService: 
totalScheduledTasks=24001, failedTaskCount=0, currentPendingTasks=0
```


Thanks,

Madhan Neethiraj

Reply via email to