----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74579/#review225717 -----------------------------------------------------------
Hi Anand, Request you to handle below reviews. security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 1 (patched) <https://reviews.apache.org/r/74579/#comment314155> Please maintain the code indentation in this file and all the newly added jsx files. We are using this Code Formatter extension - https://prettier.io/ for all the react jsx files. security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 26 (patched) <https://reviews.apache.org/r/74579/#comment314153> Please remove all the unused import declaration security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 81 (patched) <https://reviews.apache.org/r/74579/#comment314154> Please remove all the unused state declaration security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 153 (patched) <https://reviews.apache.org/r/74579/#comment314157> serviceDefs state, fetchServiceDefs(), fetchServices() and fetchZones() are never used. Please remove the complete useEffect block and the above mentioned unused functions. security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 285 (patched) <https://reviews.apache.org/r/74579/#comment314158> Remove toggleChange() security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 296 (patched) <https://reviews.apache.org/r/74579/#comment314159> Remove use of handleClosePolicyId security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 297 (patched) <https://reviews.apache.org/r/74579/#comment314160> Remove use of handleClose security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 303 (patched) <https://reviews.apache.org/r/74579/#comment314161> Remove use of openModal security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 433 (patched) <https://reviews.apache.org/r/74579/#comment314156> Is delete action available for user with ROLE_KEY_ADMIN and ROLE_USER ? security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 476 (patched) <https://reviews.apache.org/r/74579/#comment314162> Remove this line to add excludeServiceUser in searchParam. This is not required in dataset listing page. security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 480 (patched) <https://reviews.apache.org/r/74579/#comment314163> Please use different key name to set searchParam in localStorage security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx Lines 509 (patched) <https://reviews.apache.org/r/74579/#comment314164> Update the key parameter value to "dataset-listing-search-filter" security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx Lines 307 (patched) <https://reviews.apache.org/r/74579/#comment314151> Is "Governed Data" available in the permission module ? security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx Lines 316 (patched) <https://reviews.apache.org/r/74579/#comment314152> Remove id="tagButton" - Mugdha Varadkar On Sept. 2, 2023, 5:19 a.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74579/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2023, 5:19 a.m.) > > > Review request for ranger, Ankita Sinha, Madhan Neethiraj, Prashant Satam, > and Subhrat Chaudhary. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4283 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4283 > > > Repository: ranger > > > Description > ------- > > UI for GDS: dashboard, datasets > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/App.jsx bc3cf9a7a > security-admin/src/main/webapp/react-webapp/src/styles/style.css aaa54a380 > security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 6e5eb0d5b > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AccessGrantForm.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AddDatasetView.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetListing.jsx > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareListing.jsx > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBar.jsx > 4dad6cab9 > > security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx > 4d8494fc4 > > > Diff: https://reviews.apache.org/r/74579/diff/1/ > > > Testing > ------- > > Validated in local environment by manually creating and deleting datasets > from UI. > Validated dataset listing page with dataset Name is search filter. > > > Thanks, > > Anand Nadar > >
