-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74584/
-----------------------------------------------------------

(Updated Sept. 7, 2023, 12:55 p.m.)


Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan Neethiraj, 
Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave.


Bugs: RANGER-4381
    https://issues.apache.org/jira/browse/RANGER-4381


Repository: ranger


Description
-------

In Ranger backbone UI, when trying to add users to a particular permissions 
module,
when typing the user name, the user lookup is done only for users who are 
visible.
In React UI, the lookup is not being restricted to visible users.

Ideally, if a user is hidden, it would mean that the user is deleted from the 
source,
and in such scenarios, the users must not be listed for user lookups.
This is a regression from the previous UI behaviour.


Diffs (updated)
-----

  security-admin/src/main/webapp/react-webapp/src/styles/style.css aaa54a380 
  
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx
 a3e55dfbd 
  
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx
 c506ee0f8 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx
 2ba0ca068 
  
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx
 1890168e5 


Diff: https://reviews.apache.org/r/74584/diff/2/

Changes: https://reviews.apache.org/r/74584/diff/1-2/


Testing
-------

Tested changes on a cluster setup with Ranger Admin build with React JS code 
base.

Verfified the visibility functionality of users/groups listing tables, security 
zone form & permission module

Successful completion of build command :
mvn clean compile package -Psecurity-admin-react


Thanks,

Brijesh Bhalala

Reply via email to