----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74609/#review225767 -----------------------------------------------------------
agents-common/pom.xml Line 20 (original), 20 (patched) <https://reviews.apache.org/r/74609/#comment314185> Should we have the prefix "-3.0.0-20230918"? agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java Lines 51 (patched) <https://reviews.apache.org/r/74609/#comment314186> I hope this won't throw an out of bound exception, but only returns null agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java Lines 56 (patched) <https://reviews.apache.org/r/74609/#comment314187> Would there be an case where s0 to s2 will be null or not present agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java Lines 60 (patched) <https://reviews.apache.org/r/74609/#comment314188> Should we store the original string and log both here to see what the original string was transformed? - Don Bosco Durai On Sept. 18, 2023, 4:48 p.m., Barbara Eckman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74609/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2023, 4:48 p.m.) > > > Review request for ranger and madhan. > > > Repository: ranger > > > Description > ------- > > RANGER-4234: Eliminate need for splitting delimited strings into arrays in > policy conditions > > > Diffs > ----- > > agents-common/dev-support/spotbugsIncludeFile.xml PRE-CREATION > agents-common/pom.xml b753c1368 > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicy.java > 9e5a94b1a > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 7ac20764f > > agents-common/src/main/java/org/apache/ranger/plugin/util/JavaScriptEdits.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74609/diff/1/ > > > Testing > ------- > > > Thanks, > > Barbara Eckman > >
