----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74590/#review225782 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On Sept. 26, 2023, 9:13 a.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74590/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2023, 9:13 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, Nikunj Pansuriya, and Nitin Galave. > > > Bugs: RANGER-4369 > https://issues.apache.org/jira/browse/RANGER-4369 > > > Repository: ranger > > > Description > ------- > > On backbone JS, when the user tries to create a policy for Knox, the > permissions pop up box displays only one option, "Allow", but in React JS, > when the user tries to create a policy for Knox, the permissions pop up box > contains two options, > "Allow" and "Select All". > > Ideally, the options in both backbone and react JS should be the same, > and moreover, when only one option is displayed, then "Select all" option is > not required. > > Hence, it is better to remove the "Select All" option for permission pop ups > containing only one option. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx > 4d6d7d265 > security-admin/src/main/webapp/react-webapp/src/styles/style.css 6e8678a57 > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx > 821d39370 > > > Diff: https://reviews.apache.org/r/74590/diff/2/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > > > Verfified the permission items in service and policy module. > > > Successful completion of build command : > mvn clean compile package -Psecurity-admin-react > > > Thanks, > > Brijesh Bhalala > >
