----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74602/#review225790 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java Lines 626 (patched) <https://reviews.apache.org/r/74602/#comment314207> - path doesn't include parameter {datasetId}. Please review and update - given this API is specific to a dataset, consider using following path: "/dataset/{datasetId}/datashareinfo" - instead of returning PList<RangerDataShareInfo>, consider returning RangerDatasetInfo which would contain PList<RangerDataShareInfo> security-admin/src/main/java/org/apache/ranger/view/RangerDataShareInfo.java Lines 22 (patched) <https://reviews.apache.org/r/74602/#comment314208> dataShareRequestId - what detail does this field capture? security-admin/src/main/java/org/apache/ranger/view/RangerDataShareInfo.java Lines 26 (patched) <https://reviews.apache.org/r/74602/#comment314209> gdsSharedStatus: what detail does this field capture? - Madhan Neethiraj On Sept. 25, 2023, 7:46 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74602/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2023, 7:46 a.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, and Subhrat > Chaudhary. > > > Bugs: RANGER-4408 > https://issues.apache.org/jira/browse/RANGER-4408 > > > Repository: ranger > > > Description > ------- > > Get dataShares that are Linked to specfic Dataset > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 440bb4c24 > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > d2bd0789d > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 059954b46 > > security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareInDatasetDao.java > 52c441104 > > security-admin/src/main/java/org/apache/ranger/db/XXGdsSharedResourceDao.java > d3bd4d65b > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 653e397d4 > > security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java > de9014072 > > security-admin/src/main/java/org/apache/ranger/view/RangerDataShareInfo.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/74602/diff/2/ > > > Testing > ------- > > Add a dataset then link dataShares to a dataset you will get list of > dataShares that are linked to the datasetId mentioned . API > (/datashares/dataset).Need to send Query Param as dataShareHeader=false > Other query params = > dataShareHeader=false&datasetId=1&sortBy=createTime&sortType=desc&pageSize=1 > Response===================> > { > "isEnabled": true, > "dataShareId": 1, > "dataShareRequestId": 1, > "serviceName": "Resource_policy_Performance_test_50K", > "zoneName": "Gds_Security_Zone", > "resourceCount": 4, > "gdsSharedStatus": "REQUESTED", > "name": "RangerDataShare12", > "description": "This is RangerDatashare" > } > > > Thanks, > > Prashant Satam > >
