----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74605/#review225798 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Sept. 29, 2023, 9:16 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74605/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2023, 9:16 a.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, and Subhrat > Chaudhary. > > > Bugs: RANGER-4410 > https://issues.apache.org/jira/browse/RANGER-4410 > > > Repository: ranger > > > Description > ------- > > We need additional filters in GET Datashare,Dataset API, to filter list based > on zoneName, serviceName. This will be needed in Datashare listing page to > search based on zone and service.Added Distinct check as we get duplicate > response for GET by zoneId,zoneName > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 1a1a78064 > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 55c8495e4 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > 51da7d15d > > security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java > 4128d70df > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java > a07fb9ea7 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > 747cc9f17 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java > 8c0ddc65d > > > Diff: https://reviews.apache.org/r/74605/diff/4/ > > > Testing > ------- > > GET datasets by > zoneId,zoneName,serviceId,serviceName,dataShareId,dataShareName,projectid,projectName > GET dataShare by > zoneId,zoneName,serviceId,serviceName,datasetId,datasetName,projectid,projectName > GET project by > zoneId,zoneName,serviceId,serviceName,datasetId,datasetName,dataShareId,dataShareName > > > Thanks, > > Prashant Satam > >
