----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74621/#review225802 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java Lines 228 (patched) <https://reviews.apache.org/r/74621/#comment314234> findByLoginId() can return null. Please review and handle this condition - similar to RangerBaseModelService handling of createdBy and updatedBy fields. - Madhan Neethiraj On Sept. 30, 2023, 8:18 a.m., Subhrat Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74621/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2023, 8:18 a.m.) > > > Review request for ranger, Anand Nadar, Madhan Neethiraj, Monika Kachhadiya, > and Prashant Satam. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-4426 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-4426 > > > Repository: ranger > > > Description > ------- > > To be able to record details of the approver of the requests i.e. request to > add datashare in dataset and request to add dataset in project. we need an > approver field in RangerDatashareInDataset and RangerDatasetInProject. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerGds.java > a1c883356 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 424f38d9e > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 5ffa23f33 > > security-admin/src/main/java/org/apache/ranger/entity/XXGdsDataShareInDataset.java > 8c59e0898 > > security-admin/src/main/java/org/apache/ranger/entity/XXGdsDatasetInProject.java > 6babde527 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java > d32282c27 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java > 0ed51c249 > > > Diff: https://reviews.apache.org/r/74621/diff/4/ > > > Testing > ------- > > Validations done: > 1. Added approver in POST API /gds/datashare/dataset, on GET API response > approver is updated. The approver value is updated in the table > x_gds_data_share_in_dataset, for the record inserted. > 2. Added approver in POST API /gds/dataset/project, on GET API response > approver is updated. The approver value is updated in the table > x_gds_data_share_in_dataset, for the record inserted. > > Updated response: > { > "id": 1, > "guid": "b8241252-6331-4efd-9b0c-160b3defde71", > "isEnabled": true, > "createdBy": "mark", > "updatedBy": "mark", > "createTime": 1695891098216, > "updateTime": 1695891098216, > "version": 1, > "dataShareId": 1, > "datasetId": 1, > "status": "ACTIVE", > "approverId": 1 > } > > > File Attachments > ---------------- > > RANGER-4426.patch > > https://reviews.apache.org/media/uploaded/files/2023/09/28/d2094906-51a7-4dbb-a010-c5f3acefdcc6__RANGER-4426.patch > > > Thanks, > > Subhrat Chaudhary > >
