> On Oct. 23, 2023, 6:31 a.m., Subhrat Chaudhary wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceGdsInfo.java > > Lines 218 (patched) > > <https://reviews.apache.org/r/74690/diff/5/?file=2282175#file2282175line218> > > > > Do we need SharedResourceInfo here?
Good point. I updated ServiceGdsInfo to make is easier to deal with delta updates. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74690/#review225885 ----------------------------------------------------------- On Oct. 23, 2023, 3:06 p.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74690/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2023, 3:06 p.m.) > > > Review request for ranger, Ankita Sinha, Abhay Kulkarni, Monika Kachhadiya, > Prashant Satam, Ramesh Mani, Subhrat Chaudhary, and Velmurugan Periasamy. > > > Bugs: RANGER-4266 > https://issues.apache.org/jira/browse/RANGER-4266 > > > Repository: ranger > > > Description > ------- > > - REST API for plugins to download GDS info, similar to policies, tags, > userstore > - Ranger updates to increment gdsVersion in services > - updated plugins library to implicitly add GDS enricher > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/admin/client/AbstractRangerAdminClient.java > a65c18708 > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminClient.java > 22a8121ca > > agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java > 9cd0fd263 > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java > df6307eb2 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerAdminGdsInfoRetriever.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsEnricher.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerGdsInfoRetriever.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPolicyDelta.java > 6eae590c4 > > agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java > 2f4af9763 > agents-common/src/main/java/org/apache/ranger/plugin/util/JsonUtilsV2.java > 9a8546b79 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > b265e8575 > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceDefUtil.java > 489476b28 > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServiceGdsInfo.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/util/ServicePolicies.java > 225f8526b > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 19ecc1fc8 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > ea98736a1 > security-admin/src/main/java/org/apache/ranger/biz/GdsDBStore.java > 10986823d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 055c31364 > security-admin/src/main/java/org/apache/ranger/db/XXGdsDataShareDao.java > f0e64d711 > security-admin/src/main/java/org/apache/ranger/db/XXGdsDatasetDao.java > ee2d4b67b > security-admin/src/main/java/org/apache/ranger/db/XXGdsProjectDao.java > 4f214ff8d > security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java > c0f9d5c4e > > security-admin/src/main/java/org/apache/ranger/entity/XXServiceVersionInfo.java > 04f030b35 > security-admin/src/main/java/org/apache/ranger/rest/GdsREST.java 4c0a106ad > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsBaseModelService.java > e7c54385f > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareInDatasetService.java > 569509d66 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDataShareService.java > 6a93e44dc > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetInProjectService.java > d62040175 > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsDatasetService.java > 75833ea7b > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsProjectService.java > 4ccb063fe > > security-admin/src/main/java/org/apache/ranger/service/RangerGdsSharedResourceService.java > 4bdb09f4d > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java > 9bf7868d0 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 547913488 > security-admin/src/main/resources/conf.dist/security-applicationContext.xml > 807791f28 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > eadd64ab7 > security-admin/src/test/java/org/apache/ranger/biz/TestTagDBStore.java > 10c3eb4bb > > > Diff: https://reviews.apache.org/r/74690/diff/6/ > > > Testing > ------- > > - verified that the plugins successfully download GDS information > > > Thanks, > > Madhan Neethiraj > >
