----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74701/#review225952 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On Nov. 6, 2023, 12:56 p.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74701/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2023, 12:56 p.m.) > > > Review request for ranger, Dhaval Rajpara and Mugdha Varadkar. > > > Bugs: RANGER-4493 > https://issues.apache.org/jira/browse/RANGER-4493 > > > Repository: ranger > > > Description > ------- > > In Ranger admin, security zones can be now created without any > services/resources. > If a security zone is created without any service, and on the service manager > page, > if the resource based services are filtered based on the zone without any > service, > then the UI displays an image with the text "No Services". > But if the same service filtering is done for tag based services, then the UI > shows a service element for tag. > It will be better if the UI behaviour is consistent for both resource and tag > based service filtering > > In the current review request, I have improvise the code with following fixes > : > > 1)Fix for the No service page in tag based. > 2)Fix for the deleting the zone service while filtering zone. > 3)Fix for import and export button click when there are no service while > filtering zone. > > > Diffs > ----- > > security-admin/src/main/webapp/react-webapp/src/views/Home.jsx 3dee1d086 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx > 0b2f46bec > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > 2df0c4d63 > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx > d4dbc57d1 > > > Diff: https://reviews.apache.org/r/74701/diff/2/ > > > Testing > ------- > > Testing is in progress > > > Thanks, > > Brijesh Bhalala > >
