----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74739/#review225980 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Nov. 14, 2023, 8:44 a.m., Madhan Neethiraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74739/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2023, 8:44 a.m.) > > > Review request for ranger, Ankita Sinha, Abhay Kulkarni, Mehul Parikh, Monika > Kachhadiya, Ramesh Mani, Sailaja Polavarapu, Subhrat Chaudhary, and > Velmurugan Periasamy. > > > Bugs: RANGER-4529 > https://issues.apache.org/jira/browse/RANGER-4529 > > > Repository: ranger > > > Description > ------- > > moved creation of bindings from RangerRequestScriptEvaluator.evaluateScript() > to constructor, so that bindings will be reused across multiple calls to > evaluateScript() > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerAnyOfExpectedTagsPresentConditionEvaluator.java > bf57fb412 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerNoneOfExpectedTagsPresentConditionEvaluator.java > 938836f66 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptConditionEvaluator.java > 80a766566 > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerTagsAllPresentConditionEvaluator.java > 82b59d24b > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerRequestScriptEvaluator.java > 2c1fe2ac1 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerCommonConstants.java > 8081dd346 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRequestExprResolver.java > 9440d7676 > > agents-common/src/test/java/org/apache/ranger/plugin/conditionevaluator/RangerRequestScriptEvaluatorTest.java > d3e343480 > > agents-common/src/test/java/org/apache/ranger/plugin/util/RangerRequestExprResolverTest.java > 6d5edc04c > > > Diff: https://reviews.apache.org/r/74739/diff/1/ > > > Testing > ------- > > - verified that all existing tests pass successfully > > > Thanks, > > Madhan Neethiraj > >
