> On Nov. 25, 2023, 8:17 a.m., Madhan Neethiraj wrote: > > > 5)Expected : The current user should be zoneAdmin as well as dataShare > > > Admin to create/upadate shared Resource > > > > Prashant - user with one of the following privileges should be allowed to > > create/update/delete shared-resources in a dataShare > > - Datashare admin > > - Zone admin > > - Service admin > > - Ranger admin
Prashant - please ignore my earlier comment. Here is the requirement: 1. add/update shared resource: will require admin privilege on **both** dataShare and one of zone/service/Ranger 2. remove a shared resource: will require admin privilege on **either** dataShare or one of zone/service/Ranger Please make sure this patch addressed both #1 and #2. Thanks! - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74755/#review226001 ----------------------------------------------------------- On Nov. 24, 2023, 11:14 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74755/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2023, 11:14 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, Subhrat Chaudhary, and Vanita Ubale. > > > Bugs: RANGER-4558 > https://issues.apache.org/jira/browse/RANGER-4558 > > > Repository: ranger > > > Description > ------- > > User should be zoneAdmin along with datashare admin of linked sharedResource > to create/update > > Steps to check > 1)Create SecurityZone > 2)Create dataShare link SecurityZone to it > 3)Current user is only zoneAdmin not datashare admin > 4)Current User is able to create/upadate shared Resource > 5)Expected : The current user should be zoneAdmin as well as dataShare > Admin to create/upadate shared Resource > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/validation/RangerGdsValidator.java > d0a1142f6 > > > Diff: https://reviews.apache.org/r/74755/diff/1/ > > > Testing > ------- > > Steps to Check > 1)Create SecurityZone > 2)Create dataShare link SecurityZone to it > 3)Current user is zoneAdmin and datashare admin > 4)Current User is able to create/upadate shared Resource > > > Thanks, > > Prashant Satam > >
