[ 
https://issues.apache.org/jira/browse/RANGER-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790526#comment-17790526
 ] 

Pradeep Agrawal commented on RANGER-4548:
-----------------------------------------

Review request link : https://reviews.apache.org/r/74763/

> Return proper error message in the response for /tags/tags, /tags/resources 
> and /tags/types API for non admin users
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: RANGER-4548
>                 URL: https://issues.apache.org/jira/browse/RANGER-4548
>             Project: Ranger
>          Issue Type: Improvement
>          Components: Ranger
>            Reporter: Abhishek
>            Assignee: Pradeep Agrawal
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: 
> 0003-RANGER-4548-Return-proper-error-message-in-the-respo.patch
>
>
> /tags/tags and /tags/types, /tags/resources APIs are not accessible by non 
> admin users,
> but when the users make a request, a proper error message should be returned 
> stating that the users do not have privilege.
> Currently, the error message returned is not explanatory.
> Response returned for non admin users :-
> {code:java}
> <!--  Licensed to the Apache Software Foundation (ASF) under one or more  
> contributor license agreements.  See the NOTICE file distributed with  this 
> work for additional information regarding copyright ownership.  The ASF 
> licenses this file to You under the Apache License, Version 2.0  (the 
> "License"); you may not use this file except in compliance with  the License. 
>  You may obtain a copy of the License at
>       http://www.apache.org/licenses/LICENSE-2.0
>   Unless required by applicable law or agreed to in writing, software  
> distributed under the License is distributed on an "AS IS" BASIS,  WITHOUT 
> WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.  See the 
> License for the specific language governing permissions and  limitations 
> under the License.--><!DOCTYPE html><!--[if lt IE 7]><html class="no-js 
> lt-ie9 lt-ie8 lt-ie7"><![endif]--><!--[if IE 7]><html class="no-js lt-ie9 
> lt-ie8"><![endif]--><!--[if IE 8]><html class="no-js 
> lt-ie9"><![endif]--><!--[if gt IE 8]><!--><html class="no-js"><!--<![endif]-->
> <head>    <meta charset="utf-8">    <meta http-equiv="X-UA-Compatible" 
> content="IE=edge,chrome=1">    <title> Ranger - Sign In</title>    <meta 
> name="description" content="">    <meta name="viewport" 
> content="width=device-width">    <link rel="shortcut icon" 
> href="images/favicon.ico">    <link href="styles/bootstrap.min.css" 
> media="all" rel="stylesheet" type="text/css" id="bootstrap-css">    <link 
> rel="stylesheet" href="styles/font-awesome.min.css">    <link 
> href="styles/xa.css" media="all" rel="stylesheet" type="text/css">    <script 
> src="libs/bower/jquery/js/jquery-3.5.1.js"></script>    <script 
> src="scripts/prelogin/XAPrelogin.js"></script>    <script 
> type="text/javascript">        $(document).ready(function() {                
> var updateBoxPosition = function() {                    
> $('#signin-container').css({                        'margin-top' : 
> ($(window).height() - $('#signin-container').height()) / 2                    
> });                };                $(window).resize(updateBoxPosition);     
>            var queryParams = JSON.parse('{"' + 
> decodeURI((location.href.split('?')[1] || 'g=0').replace(/=/g, "\":\"")) + 
> '"}');                if(queryParams.sessionTimeout){                    
> window.alert('Session Timeout');                    
> location.replace("login.jsp");                }                
> setTimeout(updateBoxPosition, 50);            });    </script></head>
> <body class="login" style="">
>     <!-- Page content        
> ================================================== -->    <section 
> id="signin-container" style="margin-top: 4.5px;">        <div class="l-logo"> 
>            <img src="images/ranger_logo.png" alt="Ranger logo">            
> </div>            <form action="" method="post" accept-charset="utf-8">       
>          <fieldset>                    <div class="fields">                   
>      <label><i class="fa fa-user"></i> Username:</label>                      
>   <input type="text" name="username" id="username" tabindex="1" autofocus>    
>                     <label><i class="fa fa-lock"></i> Password:</label>       
>                  <input type="password" name="password" id="password" 
> tabindex="2" autocomplete="off">                    </div>                    
>     <span id="errorBox" class="help-inline" 
> style="color:white;display:none;"><span class="errorMsg"></span>              
>           <i class="fa fa-exclamation-triangle" style="color:#ae2817;"></i>   
>                      </span>                        <span 
> id="errorBoxUnsynced" class="help-inline" 
> style="color:white;display:none;">User is not available in HDP Admin Tool. 
> Please contact your Administrator.                        <i class="fa 
> fa-exclamation-triangle" style="color:#ae2817;"></i>                    
> </span>                        <button type="submit" class="btn btn-primary 
> btn-block" id="signIn" tabindex="4" >                        Sign In          
>               <i id="signInLoading" class="fa fa-spin fa-spinner" 
> style="display: none;"></i>                    </button>                
> </fieldset>            </form>    </section></body>
> </html> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to