----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74740/#review226040 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On Dec. 12, 2023, 9:37 a.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74740/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2023, 9:37 a.m.) > > > Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Madhan > Neethiraj, Mehul Parikh, Mugdha Varadkar, and Nikunj Pansuriya. > > > Bugs: RANGER-4519 > https://issues.apache.org/jira/browse/RANGER-4519 > > > Repository: ranger > > > Description > ------- > > Update ServiceDef icons in service manager page. > > The service manager page currently uses a folder icon for displaying > ServiceDefs. > We should update this to show a real logo or icon that is specific to each > ServiceDef. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/atlas/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/elasticsearch/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hbase/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hdfs/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/hive/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kafka/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/knox/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kudu/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/kylin/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi-registry/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/nifi/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/ozone/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/presto/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/schema-registry/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/solr/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/sqoop/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/storm/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/trino/icon.svg > PRE-CREATION > > security-admin/src/main/webapp/react-webapp/src/images/serviceDefIcons/yarn/icon.svg > PRE-CREATION > security-admin/src/main/webapp/react-webapp/src/styles/style.css 10f47923b > security-admin/src/main/webapp/react-webapp/src/utils/XAUtils.js 9f6706261 > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx > bedce6f4b > > > Diff: https://reviews.apache.org/r/74740/diff/2/ > > > Testing > ------- > > Tested changes on a cluster setup with Ranger Admin build with React JS code > base. > Verified the logos are visible for services in Service Manager landing page. > > > Thanks, > > Brijesh Bhalala > >
