----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74728/#review226049 -----------------------------------------------------------
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx Line 218 (original), 218 (patched) <https://reviews.apache.org/r/74728/#comment314372> We have below solutions to handle this, 1) We can use hideSelectedOptions props of react-select to hide the selected option from the menu so that onChange is not triggered for the same value. 2) Update the logic in onChange to check if the selected value does match the currently selected value, then simply do nothing security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx Line 232 (original), 240 (patched) <https://reviews.apache.org/r/74728/#comment314373> Please refer above review comments from above. - Mugdha Varadkar On Nov. 9, 2023, 9:46 a.m., Brijesh Bhalala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74728/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2023, 9:46 a.m.) > > > Review request for ranger, Dhaval Rajpara and Mugdha Varadkar. > > > Bugs: RANGER-4513 > https://issues.apache.org/jira/browse/RANGER-4513 > > > Repository: ranger > > > Description > ------- > > The policy listing page experiences an unexpected reset when attempting to > filter the service and zone dropdown options. > > Steps to Reproduce: > 1)Navigate to the "hive" policy listing page. > 2)Goto Masking tab > 3)Select the "Service" dropdown to filter policies based on a specific > service. > 4)Select the "Zone" dropdown to filter policies based on specific zone. > 5)Observe that the page resets to the default "Access" tab > > Expected Behavior: > > The page should retain the selected tab when filtering the service and zone > dropdown. > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListingTabView.jsx > 44d9f1da9 > security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx > d4dbc57d1 > > > Diff: https://reviews.apache.org/r/74728/diff/1/ > > > Testing > ------- > > Testing is in progress > > > Thanks, > > Brijesh Bhalala > >
