> On Jan. 10, 2024, 6:49 a.m., Ramachandran Krishnan wrote: > > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java > > Line 400 (original) > > <https://reviews.apache.org/r/74828/diff/1/?file=2284717#file2284717line403> > > > > I feel still we can include debug messages > > if(logger.isDebugEnabled()) { > > logger.debug("<== > > PublicAPIs.countRepositories(): count=" + ret); > > } > > > > > > if(logger.isDebugEnabled()) { > > logger.debug("<== PublicAPIs.countPolicies(): " > > + request ); > > }
There is a debug message before the statement "return assetREST.countXResources(request);". Can you please let me know if more debug statements are required? Thanks - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74828/#review226116 ----------------------------------------------------------- On Jan. 10, 2024, 5:41 a.m., Abhishek Patil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74828/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2024, 5:41 a.m.) > > > Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, > Pradeep Agrawal, and Ramesh Mani. > > > Bugs: RANGER-4636 and RANGER-4637 > https://issues.apache.org/jira/browse/RANGER-4636 > https://issues.apache.org/jira/browse/RANGER-4637 > > > Repository: ranger > > > Description > ------- > > If the number of policies / repositories is greater than 200, the > /public/api/policy/count and the /public/api/repository/count APIs do not > return the correct value. > This patch addresses the issue. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java > a6b86e965 > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > 180742bcd > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java > eb0cb6452 > security-admin/src/test/java/org/apache/ranger/rest/TestXAuditREST.java > 2864cd36c > > > Diff: https://reviews.apache.org/r/74828/diff/1/ > > > Testing > ------- > > 1. Applied the patch on a cluster, created more than 300 policies and 300 > services, and ensured that the proper values are returned for > /public/api/policy/count and /public/api/repository/count APIs. > 2. The associated unit tests have also been modified according to the code > change, and the unit tests were run by triggering a maven build. > The unit tests passed > > > Thanks, > > Abhishek Patil > >
