----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74806/#review226121 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Dec. 28, 2023, 6:16 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74806/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2023, 6:16 a.m.) > > > Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan > Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita > Ubale. > > > Bugs: RANGER-4628 > https://issues.apache.org/jira/browse/RANGER-4628 > > > Repository: ranger > > > Description > ------- > > For Partial Update of Security-Zone API ===> > /service/public/v2/api/zones-v2/{id}/partial > > 1)We can add existing admins/auditors to the zone and still get 200 as > response > > 2)We can add existing tagServices to the zone and still get 200 as response > > 3)While removing the existing resources in zone if we pass invalid > serviceName we still get 200 as response though the zone is not getting > updated > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerSecurityZoneHelper.java > 72ec4a4c7 > > > Diff: https://reviews.apache.org/r/74806/diff/1/ > > > Testing > ------- > > steps to check : > 1)We get validation when adding existing admins/auditors to the zone > 2)We get validation when adding existing tagServices to the zone > 3)We get validation when pass invalid serviceName for removing existing > resources from zone > > > Thanks, > > Prashant Satam > >
