----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74841/#review226156 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java Lines 2173 (patched) <https://reviews.apache.org/r/74841/#comment314435> updateDatasetPolicy()/updateProjectPolicy() can fail if the caller is not have admin or dataset/project admin privilege. Consider handling this inside ServiceDBStore.updatePolicy(), to call updateGdsVersionForDataset()/ updateGdsVersionForProject() for GDS service policies. - Madhan Neethiraj On Jan. 18, 2024, 6:51 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74841/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2024, 6:51 a.m.) > > > Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan > Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita > Ubale. > > > Bugs: RANGER-4662 > https://issues.apache.org/jira/browse/RANGER-4662 > > > Repository: ranger > > > Description > ------- > > Currently when we delete user,group which is referenced in gds policy then > GdsVersion (can check by GET API /service/gds/download/{serviceName})is not > updated after the action it needs to be updated. > > Steps : > > 1)create a user and resource service > > 2)create a dataset , and dataShare (with the resource service),and a > sharedResource (with dataShare),also create mapping of dataset with dataShare > as ACTIVE > > 3)create a GDS policy for the dataset > > 4)Update dataset policy and add created user to it for this actions the > GdsVersion is updated we can check by (GET API > /service/gds/download/{serviceName}) > > 5)but when we delete the created user which is in Gds dataset policy then the > GdsVersion is not updated we need to update it > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 287400259 > security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java > ce48c8279 > > > Diff: https://reviews.apache.org/r/74841/diff/1/ > > > Testing > ------- > > Steps to check : > 1)create a user and resource service > > 2)create a dataset , and dataShare (with the resource service),and a > sharedResource (with dataShare),also create mapping of dataset with dataShare > as ACTIVE > > 3)create a GDS policy for the dataset > > 4)Update dataset policy and add created user to it > > 5)when we delete the created user then the GdsVersion is updated > > > Thanks, > > Prashant Satam > >
