----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74849/#review226168 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Jan. 22, 2024, 1:29 p.m., Abhishek Patil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74849/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2024, 1:29 p.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, > Mehul Parikh, Mugdha Varadkar, and Ramesh Mani. > > > Bugs: RANGER-4654 > https://issues.apache.org/jira/browse/RANGER-4654 > > > Repository: ranger > > > Description > ------- > > Whenever a datashare or a dataset is being created/updated with a name which > is already present, > then the UI shows "Data not found" message and shows options to return to > home page. > The error has to be handled gracefully. > Ideally, in such scenarios, the user should be able to modify the dataset / > datashare creation form by changing the name and submit the same form with > other existing details (This is the behavior with policy / service > creation/update form). > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/AddDatasetView.jsx > 7851e7c26 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Dataset/DatasetDetailLayout.jsx > a8857e0eb > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/AddSharedResourceComp.jsx > 23c34d2e7 > > security-admin/src/main/webapp/react-webapp/src/views/GovernedData/Datashare/DatashareDetailLayout.jsx > b6c83c9cd > > > Diff: https://reviews.apache.org/r/74849/diff/1/ > > > Testing > ------- > > 1. Dataset creation with an existing name > Tried to create a dataset with an existing name, an error was shown that a > dataset with the same name exists and the page was not redirected to "Data > not found". > The user can go back in the same form and edit the dataset name, and submit > the form again, rest of the details are saved. > > 2. Edit the dataset and try to set the name to an existing name > The form is submitted, but an error is shown that a dataset with an existing > name is present, and the user can edit the dataset name. > The page is not redirected to "Data not found". > > 3. Datashare edit form with an existing datashare name > The form is submitted, but an error is shown that a dataset with an existing > name is present, and the user can edit the datashare name. > The page is not redirected to "Data not found". > > 4. Datashare create form with an existing datatshare name > No changes to this form as the issue was already handled. > The page does not redirect to "Data not found". > > 5. Shared resource creation with an existing resource name > Earlier, if a user tried creating a shared resource with an existing name, > the error message displayed was "Validation failure", and it was not > descriptive. > The issue has been fixed to display the proper error message. > > > Thanks, > > Abhishek Patil > >
