----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74819/#review226176 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java Lines 204 (patched) <https://reviews.apache.org/r/74819/#comment314455> This creation of admin audit should be inside if(tagDef != null) check - Anand Nadar On Jan. 5, 2024, 9:52 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74819/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2024, 9:52 a.m.) > > > Review request for ranger, Akshay Tupe, Anand Nadar, Ankita Sinha, Madhan > Neethiraj, Monika Kachhadiya, Siddhesh Phatak, Subhrat Chaudhary, and Vanita > Ubale. > > > Bugs: RANGER-4633 > https://issues.apache.org/jira/browse/RANGER-4633 > > > Repository: ranger > > > Description > ------- > > Currently when we ADD/UPDATE/DELETE tag and tagdef we dont generate > Transaction logs for it so we dont get Admin Audits for this operations it > will be helpful if we generate them > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > fb912d4f8 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java > 8f677995b > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > 3a90bd8a9 > > > Diff: https://reviews.apache.org/r/74819/diff/1/ > > > Testing > ------- > > Tested we get transaction logs during ADD/UPDATE/DELETE of tag and tagdef > > 1)Tag = we get transaction logs for UPDATE operation for fields > owner,attributes,options,validityPeriods > 2)TagDef = we get transaction logs for UPDATE operation for fields > source,attributeDefs > > > Thanks, > > Prashant Satam > >
