----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74811/#review226191 -----------------------------------------------------------
Ship it! Ship It! - Anand Nadar On Jan. 3, 2024, 10:01 a.m., Prashant Satam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74811/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2024, 10:01 a.m.) > > > Review request for ranger, Anand Nadar, Ankita Sinha, Madhan Neethiraj, > Monika Kachhadiya, and Subhrat Chaudhary. > > > Bugs: RANGER-4630 > https://issues.apache.org/jira/browse/RANGER-4630 > > > Repository: ranger > > > Description > ------- > > Currently for Tag related GET-APIs i.e for > (RangerTags,RangerTagDefs,RangerServiceResource) we dont support > pagination,and also we need additional searchFilters for them > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 0f6611f45 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > de72ff140 > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java 6d0019f70 > security-admin/src/main/java/org/apache/ranger/rest/TagRESTConstants.java > 9e78cf0e8 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java > 3a4ccf83d > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceServiceBase.java > 329d3eeec > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java > 8f677995b > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefServiceBase.java > 929a4b06b > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > 3a90bd8a9 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagServiceBase.java > 2e2c04f47 > > > Diff: https://reviews.apache.org/r/74811/diff/1/ > > > Testing > ------- > > 1)Tags > Request ====> /service/tags/tags? > Supported Query Params > Search Fields > tagId,tagDefId,tagType,tagTypePartial > Sort Fields > tagId,tagDefId,createTime,updateTime > Supports Pagination > > 2)TagDefs > Request ====> /service/tags/tagdefs? > Supported Query Params > Search Fields > tagDefId,tagDefGuid,tagType,tagTypePartial,tagSource, > tagSourcePartial > Sort Fields > tagDefId,tagType,createTime,updateTime > Supports Pagination > > 3)ServiceResource > Request ====> /service/tags/resources? > Supported Query Params > Search Fields > resourceId,tagServiceId,tagServiceName,tagServiceNamePartial,resourceGuid,resourceSignature > Sort Fields > resourceId,tagServiceId,createTime,updateTime > Supports Pagination > > > Thanks, > > Prashant Satam > >
