----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74903/#review226236 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Feb. 23, 2024, 1:17 p.m., Anand Nadar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74903/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2024, 1:17 p.m.) > > > Review request for ranger, Asit Vadhavkar, Madhan Neethiraj, Monika > Kachhadiya, Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4724 > https://issues.apache.org/jira/browse/RANGER-4724 > > > Repository: ranger > > > Description > ------- > > When the response json of tags download api is used as input for the > importservicetags api, at attempt to create an existing resource because the > response of tags download api does not have serviceName in the resources > level. > To fix this, we are using the serviceName in the ServiceTags object when it > is not present in the resources object. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/rest/ServiceTagsProcessor.java > f29304036 > > > Diff: https://reviews.apache.org/r/74903/diff/1/ > > > Testing > ------- > > Validated PUT /tags/importsevicetags/ api, with default json structure of > ServiceTags. > Validated PUT /tags/importsevicetags/ api, with response of > /tags/download/{serviceName} api > > > Thanks, > > Anand Nadar > >
