----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74935/#review226386 -----------------------------------------------------------
Ship it! Ship It! - Mugdha Varadkar On March 8, 2024, 3:48 p.m., Abhishek Patil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74935/ > ----------------------------------------------------------- > > (Updated March 8, 2024, 3:48 p.m.) > > > Review request for ranger, Brijesh Bhalala, Dhaval Rajpara, Madhan Neethiraj, > Mehul Parikh, Mugdha Varadkar, and Ramesh Mani. > > > Bugs: RANGER-4653 > https://issues.apache.org/jira/browse/RANGER-4653 > > > Repository: ranger > > > Description > ------- > > Currently, in the Service creation / edit form in Ranger react UI, there is a > validation for display name which does not allow spaces in displayName. The > validation has to be modified to include spaces, otherwise it won't allow > edit of Service from UI if the display name contains a space > > > Diffs > ----- > > > security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx > be179a981 > > > Diff: https://reviews.apache.org/r/74935/diff/1/ > > > Testing > ------- > > Applied the patch on a cluster and tested the following scenarios :- > 1. Ensured that service creation is allowed for a display name containing a > space > 2. Ensured that service update operation is allowed for a display name > containing a space > 3. Ensured that service creation / update fails if service display name > contains a special character / if the name is longer than 255 characters. > > > Thanks, > > Abhishek Patil > >
