----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/75015/#review226555 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java Line 58 (original) <https://reviews.apache.org/r/75015/#comment314826> This patch doesn't include the relocated inner class AuditIndexRecord and enum SPOOL_FILE_STATUS. Please review and update. - Madhan Neethiraj On June 13, 2024, 7:13 p.m., Monika Kachhadiya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/75015/ > ----------------------------------------------------------- > > (Updated June 13, 2024, 7:13 p.m.) > > > Review request for ranger, Anand Nadar, Asit Vadhavkar, Madhan Neethiraj, > Siddhesh Phatak, and Subhrat Chaudhary. > > > Bugs: RANGER-4806 > https://issues.apache.org/jira/browse/RANGER-4806 > > > Repository: ranger > > > Description > ------- > > The root as mentioned here: > https://github.com/google/gson/issues/1979#issuecomment-927943566 > > Similar to #1963 and other existing reports. Apparently you are deserializing > a JDK class (java.security.KeyFactory) without having specified a custom type > adapter for it. Gson will then by default use a reflection based type > adapter. You have to write a custom type adapter to solve this issue or move > to jackson fasterxml. > > This patch is to move from Gson to jackson fasterxml. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > 2e32fb579 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/BaseAuditHandler.java > 68c33c90d > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > 1e5d1d8d8 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java > bc8f685c3 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileQueueSpool.java > 26e11aba9 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileSpool.java > 3f40861b0 > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java > f73df2c20 > > agents-common/src/main/java/org/apache/ranger/authorization/utils/JsonUtils.java > 8113e4280 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerFileBasedTagRetriever.java > df2c7ccf1 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > c5f5fc3be > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerUserStoreRefresher.java > fe0b92334 > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/externalretrievers/GetFromURL.java > f9eae3574 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 92ce183bb > > agents-common/src/main/java/org/apache/ranger/plugin/util/PolicyRefresher.java > aa0c80119 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerMetricsUtil.java > 588605a6a > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTClient.java > e54313403 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRolesProvider.java > 58a47cf1b > security-admin/src/main/java/org/apache/ranger/biz/KmsKeyMgr.java c9a9987c8 > > security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java > 321148307 > security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java > a15ceac56 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 738d92e48 > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > 63bde37d8 > > security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java > c768f1c34 > security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java f910e92ee > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 8af4448b5 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForSyncSourceUpdate_J10054.java > 99de47310 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForXGlobalState_J10036.java > 5506625bc > > security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java > 7d4828ed0 > security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 844a363fb > > security-admin/src/main/java/org/apache/ranger/service/RangerRoleService.java > b815b1d37 > > security-admin/src/main/java/org/apache/ranger/service/RangerSecurityZoneServiceService.java > 48be2b5fe > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceService.java > 918c8d009 > > security-admin/src/main/java/org/apache/ranger/service/RangerServiceResourceWithTagsService.java > 2b3acd17a > > security-admin/src/main/java/org/apache/ranger/service/RangerTagDefService.java > c779b7746 > > security-admin/src/main/java/org/apache/ranger/service/RangerTagService.java > fe79c3e5f > > tagsync/src/main/java/org/apache/ranger/tagsync/model/AbstractTagSource.java > ff9937628 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 9a761b33c > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/AtlasRESTTagSource.java > 792ced132 > > tagsync/src/main/java/org/apache/ranger/tagsync/source/file/FileTagSource.java > 65deccd14 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXGroupListResponse.java > c0e8a0986 > > ugsync/src/main/java/org/apache/ranger/unixusersync/model/GetXUserListResponse.java > 16ad7d6e4 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/FileSourceUserGroupBuilder.java > 9c951a668 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > fecd96de0 > > > Diff: https://reviews.apache.org/r/75015/diff/3/ > > > Testing > ------- > > Sanity test of CRUD policies/users/groups from ranger UI > Verified existing junits test cases are working as expected > verified audit spool is generated as expected in case of java 17 > > > Thanks, > > Monika Kachhadiya > >
